-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable python 3.13 wheels #237
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
- Coverage 74.68% 74.30% -0.38%
==========================================
Files 157 157
Lines 22907 22907
==========================================
- Hits 17107 17022 -85
- Misses 5800 5885 +85 ☔ View full report in Codecov by Sentry. |
Need to update the I have to do it manually because of #209 |
@gipert I tend to build and push the docker images from GitHub Actions. Mainly because they are completely free. I do 20-30 images for our Geant4 project. Shall I set up the actions on our docker repo? |
I guess we could do that. We would need to set it up in https://github.com/g4edge/dockerfiles and also here, and move the pyg4ometry image source from https://github.com/g4edge/dockerfiles to here... |
Surely we just set up the action on the 4edge/dockerfiles and push the images to dockerhub. Then everything else should work as normal. So basically on release of the g4edge/dockerfiles repo, update the images and push, a bit like this https://github.com/bdsim-collaboration/docker/blob/main/.github/workflows/docker-build.yml |
The builds are failing on usd-core, I will make this an optional dep until it is available for python 3.13 |
but then we would need to manually trigger a build of the pyg4ometry image, every time we release a new pyg4ometry version. right? |
Ok. You are right, my solution works for the manylinux docker image needed for building a deployment version, but not the pyg4ometry docker images. Having said this could just move the building of the complete pyg4ometry images over to the main repo |
I re-triggered the wheel builds here: https://github.com/g4edge/pyg4ometry/actions/runs/13524656884 |
macOS and windows 3.13 wheels are not built yet (they have to be enbabled in |
Thanks Manuel, retriggered here: https://github.com/g4edge/pyg4ometry/actions/runs/13525507416 |
seems like it worked 🎉 thanks everyone. I'll merge and release a new version. |
No description provided.